Repository navigation
Correct Core logging and knob caller documentation - #2413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the logger headers to describe
CoreStoragePaths.logs/app.jsonland its default Application Support location. Point the knob docs at the actual FluidAudioCompatibility and SpeakerEmbeddingThresholds callers.This extracts only the recoverable factual portion of CORE-REST-19 already present in broad #2336. The report’s truncated remainder remains unclaimed. No runtime changes; #2336 remains untouched.
Validation: independent full diff/source review GREEN. Guarded
bash check.shpreserves its overall FAIL: 17 source checks PASS, six runtime/build commands deliberately blocked with exit 3, one orchestration preflight SKIP; standalone preflight passed. Raw exact-head proof archived before verification. Guardedverify-change.shfailed at the blocked dependency build before app launch; no runtime, native, model or owner-profile execution. Hosted/exact-head CI remains pending. The separate frozen Wave 3 union is not this PR’s exact-head proof.